killzoner commented on code in PR #1394:
URL:
https://github.com/apache/datafusion-ballista/pull/1394#discussion_r2705872478
##########
ballista/core/src/execution_plans/shuffle_writer.rs:
##########
@@ -263,6 +263,10 @@ impl ShuffleWriterExec {
let mut partitioner = BatchPartitioner::try_new(
Partitioning::Hash(exprs, num_output_partitions),
write_metrics.repart_time.clone(),
+ input_partition,
+ // we can keep num_input_partitions to 1, it's not
used in case of hash partitioning
+ // see
https://github.com/apache/datafusion/blob/52.0.0/datafusion/physical-plan/src/repartition/mod.rs#L507
+ 1,
Review Comment:
this is the most arguable change, doc says 0 is not supported so I put 1,
but it's not used anyway downstream for hash partition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
