timsaucer commented on PR #19437: URL: https://github.com/apache/datafusion/pull/19437#issuecomment-3770108861
Ok @adriangb @milenkovicm @LiaCastaneda I think this is ready for review now. I'm really glad I added in a round trip unit test to verify the number of times we hit each method because it pointed out the same flaw @LiaCastaneda described. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
