wForget commented on code in PR #3214:
URL: https://github.com/apache/datafusion-comet/pull/3214#discussion_r2706444516
##########
native/core/src/execution/operators/parquet_writer.rs:
##########
@@ -535,8 +535,12 @@ impl ExecutionPlan for ParquetWriterExec {
DataFusionError::Execution(format!("Failed to close writer:
{}", e))
})?;
- // Get file size
- let file_size = std::fs::metadata(&part_file)
+ // Get file size - strip file:// prefix if present for local
filesystem access
+ let local_path = part_file
+ .strip_prefix("file://")
+ .or_else(|| part_file.strip_prefix("file:"))
+ .unwrap_or(&part_file);
+ let file_size = std::fs::metadata(local_path)
Review Comment:
A question unrelated to this PR: #2929 supports write to hdfs. So, is the
logic here correct when local_path is an hdfs path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
