Jefffrey commented on code in PR #19868:
URL: https://github.com/apache/datafusion/pull/19868#discussion_r2707443438
##########
datafusion/functions-nested/src/sort.rs:
##########
@@ -137,10 +137,18 @@ impl ScalarUDFImpl for ArraySort {
match &arg_types[0] {
DataType::Null => Ok(DataType::Null),
DataType::List(field) => {
- Ok(DataType::new_list(field.data_type().clone(), true))
+ // Preserve the inner field's nullability from input
Review Comment:
Why are these changes coming back again?
##########
docs/source/_static/data/deps.svg:
##########
Review Comment:
Please remove this file
##########
datafusion/functions-aggregate/src/array_agg.rs:
##########
@@ -737,13 +786,8 @@ impl Accumulator for OrderSensitiveArrayAggAccumulator {
}
fn state(&mut self) -> Result<Vec<ScalarValue>> {
- if !self.is_input_pre_ordered {
Review Comment:
Why are we removing this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
