kumarUjjawal commented on code in PR #19888:
URL: https://github.com/apache/datafusion/pull/19888#discussion_r2707983423
##########
datafusion/functions/src/math/cot.rs:
##########
@@ -96,24 +96,47 @@ impl ScalarUDFImpl for CotFunc {
}
fn invoke_with_args(&self, args: ScalarFunctionArgs) ->
Result<ColumnarValue> {
- make_scalar_function(cot, vec![])(&args.args)
- }
-}
-
-///cot SQL function
-fn cot(args: &[ArrayRef]) -> Result<ArrayRef> {
- match args[0].data_type() {
- Float64 => Ok(Arc::new(
- args[0]
- .as_primitive::<Float64Type>()
- .unary::<_, Float64Type>(|x: f64| compute_cot64(x)),
- ) as ArrayRef),
- Float32 => Ok(Arc::new(
- args[0]
- .as_primitive::<Float32Type>()
- .unary::<_, Float32Type>(|x: f32| compute_cot32(x)),
- ) as ArrayRef),
- other => exec_err!("Unsupported data type {other:?} for function cot"),
+ let return_type = args.return_type().clone();
+ let [arg] = take_function_args(self.name(), args.args)?;
+
+ match arg {
+ ColumnarValue::Scalar(scalar) => {
+ if scalar.is_null() {
+ return ColumnarValue::Scalar(ScalarValue::Null)
+ .cast_to(&return_type, None);
+ }
+
+ match scalar {
+ ScalarValue::Float64(Some(v)) => Ok(ColumnarValue::Scalar(
+ ScalarValue::Float64(Some(compute_cot64(v))),
+ )),
+ ScalarValue::Float32(Some(v)) => Ok(ColumnarValue::Scalar(
+ ScalarValue::Float32(Some(compute_cot32(v))),
+ )),
+ _ => {
+ internal_err!(
+ "Unexpected scalar type for cot: {:?}",
+ scalar.data_type()
+ )
+ }
+ }
+ }
+ ColumnarValue::Array(array) => match array.data_type() {
+ Float64 => Ok(ColumnarValue::Array(Arc::new(
+ array
+ .as_primitive::<Float64Type>()
+ .unary::<_, Float64Type>(compute_cot64),
+ ))),
+ Float32 => Ok(ColumnarValue::Array(Arc::new(
+ array
+ .as_primitive::<Float32Type>()
+ .unary::<_, Float32Type>(compute_cot32),
+ ))),
+ other => {
+ internal_err!("Unexpected data type {other:?} for function
cot")
Review Comment:
If we reach the other => branch, it means the type coercion/signature code
has a bug, this should never happen in normal execution, hence `internal_err`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
