kosiew commented on code in PR #19884:
URL: https://github.com/apache/datafusion/pull/19884#discussion_r2716601540
##########
datafusion/core/tests/custom_sources_cases/dml_planning.rs:
##########
@@ -295,3 +619,127 @@ async fn test_unsupported_table_update() -> Result<()> {
assert!(result.is_err() || result.unwrap().collect().await.is_err());
Ok(())
}
+
+#[tokio::test]
+async fn test_delete_target_table_scoping() -> Result<()> {
+ // Test that DELETE only extracts filters from the target table,
+ // not from other tables (important for DELETE...FROM safety)
+ let target_provider =
Arc::new(CaptureDeleteProvider::new_with_filter_pushdown(
+ test_schema(),
+ TableProviderFilterPushDown::Exact,
+ ));
+ let ctx = SessionContext::new();
+ ctx.register_table(
+ "target_t",
+ Arc::clone(&target_provider) as Arc<dyn TableProvider>,
+ )?;
+
+ // For now, we test single-table DELETE
+ // and validate that the scoping logic is correct
+ let df = ctx.sql("DELETE FROM target_t WHERE id > 5").await?;
+ df.collect().await?;
+
+ let filters = target_provider
+ .captured_filters()
+ .expect("filters should be captured");
+ assert_eq!(filters.len(), 1);
+ assert!(
+ filters[0].to_string().contains("id"),
+ "Filter should be for id column"
+ );
+ assert!(
+ filters[0].to_string().contains("5"),
+ "Filter should contain the value 5"
+ );
+ Ok(())
+}
+
+#[tokio::test]
+async fn test_update_from_drops_non_target_predicates() -> Result<()> {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
