16pierre commented on code in PR #19928:
URL: https://github.com/apache/datafusion/pull/19928#discussion_r2717110514
##########
datafusion/proto-common/src/generated/prost.rs:
##########
@@ -815,6 +815,10 @@ pub struct ParquetOptions {
pub max_row_group_size: u64,
#[prost(string, tag = "16")]
pub created_by: ::prost::alloc::string::String,
+ #[prost(oneof = "parquet_options::PruningMaxInlistLimitOpt", tags = "35")]
+ pub pruning_max_inlist_limit_opt: ::core::option::Option<
+ parquet_options::PruningMaxInlistLimitOpt,
+ >,
Review Comment:
In general in this PR I hesitated at which level we should starting wiring
`PruningPredicateConfig` vs wiring the individual usize
`pruning_max_inlist_limit`.
On the `ParquetOptions` Rust struct I tried to follow the existing standards
of "flat types", so I mirrored the exact same structure on the protobuf
objects.
If I understand correctly, you're suggesting we introduce an explicit
protobuf type for `PruningPredicateConfig` in the `ParquetOptions` proto
format, without changing the current rust-side `ParquetOptions` struct ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
