andygrove commented on code in PR #3247:
URL: https://github.com/apache/datafusion-comet/pull/3247#discussion_r2718916933
##########
native/core/src/execution/planner.rs:
##########
@@ -2589,6 +2650,105 @@ fn convert_spark_types_to_arrow_schema(
arrow_schema
}
+/// Converts a protobuf PartitionValue to an iceberg Literal.
+///
+/// This replaces JSON parsing with direct protobuf deserialization with a
more compact
+/// representation (e.g., timestamps as integers vs strings).
Review Comment:
nit: we can remove the part of the comment that explains how this used to
work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
