hsiang-c commented on code in PR #3242:
URL: https://github.com/apache/datafusion-comet/pull/3242#discussion_r2718356540
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -414,10 +416,12 @@ abstract class CometNativeExec extends CometExec {
def convertBlock(): CometNativeExec = {
def transform(arg: Any): AnyRef = arg match {
case serializedPlan: SerializedPlan if serializedPlan.isEmpty =>
- val out = new ByteArrayOutputStream()
- nativeOp.writeTo(out)
- out.close()
- SerializedPlan(Some(out.toByteArray))
+ val size = nativeOp.getSerializedSize
Review Comment:
(minor) We could extract some of the shared code to a utility method but not
urgent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
