kadinrabo opened a new pull request, #19945:
URL: https://github.com/apache/datafusion/pull/19945

   ## Which issue does this PR close?
   
   - Closes #19944.
   
   ## Rationale for this change
   
   See issue for details.
   
   ## What changes are included in this PR?
   
   Replaces type variation hacks with `UserDefined` extension types from 
Arrow's 
[extension_types.yaml](https://github.com/apache/arrow/blob/main/format/substrait/extension_types.yaml):
   
   - UInt8/16/32/64 → `u8`, `u16`, `u32`, `u64`
   - LargeUtf8/LargeBinary/LargeList → `large_string`, `large_binary`, 
`large_list`
   - Decimal256, Duration, Date64, Time32, Time64, FixedSizeList
   
   Plans now include `extension_uris` referencing the Arrow URI. Old variation 
constants are deprecated but the consumer maintains backwards compatibility.
   
   ## Are these changes tested?
   
   Yes. All 179 existing substrait tests pass, including round-trip tests for 
all affected types.
   
   ## Are there any user-facing changes?
   
   No breaking changes. Generated Substrait plans use the new extension type 
format, but the consumer accepts both old and new formats.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to