andygrove commented on code in PR #3249:
URL: https://github.com/apache/datafusion-comet/pull/3249#discussion_r2719517747


##########
.github/workflows/pr_build_linux.yml:
##########
@@ -60,15 +100,29 @@ jobs:
       image: amd64/rust
     steps:
       - uses: actions/checkout@v6
+
       - name: Setup Rust & Java toolchain
         uses: ./.github/actions/setup-builder
         with:
-          rust-version: ${{env.RUST_VERSION}}
+          rust-version: ${{ env.RUST_VERSION }}
           jdk-version: ${{ matrix.java_version }}
+
+      - name: Cache Cargo
+        uses: actions/cache@v4

Review Comment:
   The `linux-test-rust` job uses debug builds (cargo test) while 
`build-native` uses the CI profile, so their native/target artifacts are 
incompatible. Sharing the same cache key would cause cache thrashing, where 
each job overwrites the other's compiled artifacts, if I'm understanding this 
correctly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to