martin-g commented on code in PR #19924:
URL: https://github.com/apache/datafusion/pull/19924#discussion_r2720512712
##########
datafusion/common/src/config.rs:
##########
@@ -3065,6 +3065,22 @@ config_namespace! {
/// If not specified, the default level for the compression algorithm
is used.
pub compression_level: Option<u32>, default = None
pub schema_infer_max_rec: Option<usize>, default = None
+ /// The format of JSON input files.
+ ///
+ /// When `false` (default), expects newline-delimited JSON (NDJSON):
+ /// ```text
+ /// {"key1": 1, "key2": "val"}
+ /// {"key1": 2, "key2": "vals"}
+ /// ```
+ ///
+ /// When `true`, expects JSON array format:
+ /// ```text
+ /// [
+ /// {"key1": 1, "key2": "val"},
+ /// {"key1": 2, "key2": "vals"}
+ /// ]
+ /// ```
+ pub format_array: bool, default = false
Review Comment:
IMO it would be better to use an enum here, e.g. `JSON_FORMAT {NDJSON,
ARRAY}`.
It will be more clear than true/false and also easier to extend with a
third, fourth, ... formats later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
