andygrove opened a new pull request, #2175: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2175
## Summary Continues the work from #2171 by replacing 12 more `dialect_of!` macro usages with proper `Dialect` trait methods. This allows user-defined dialects to customize parsing behavior and makes the differences between dialects more clearly documented in the trait. **New trait methods added:** | Method | Description | Dialects | |--------|-------------|----------| | `supports_select_wildcard_replace` | `SELECT * REPLACE` syntax | BigQuery, ClickHouse, DuckDB, Snowflake | | `supports_select_wildcard_ilike` | `SELECT * ILIKE` syntax | Snowflake | | `supports_select_wildcard_rename` | `SELECT * RENAME` syntax | Snowflake | | `supports_optimize_table` | `OPTIMIZE TABLE` statement | ClickHouse | | `supports_install` | `INSTALL` statement | DuckDB | | `supports_detach` | `DETACH` statement | DuckDB | | `supports_prewhere` | `PREWHERE` clause | ClickHouse | | `supports_with_fill` | `WITH FILL` in ORDER BY | ClickHouse | | `supports_limit_by` | `LIMIT BY` clause | ClickHouse | | `supports_interpolate` | `INTERPOLATE` clause | ClickHouse | | `supports_settings` | `SETTINGS` clause | ClickHouse | | `supports_select_format` | `FORMAT` clause in SELECT | ClickHouse | All methods are also implemented for `GenericDialect` (returning `true`). ## Test plan - [x] All existing tests pass - [x] `cargo clippy` passes - [x] `cargo fmt` passes 🤖 Generated with [Claude Code](https://claude.ai/code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
