andygrove opened a new pull request, #3253: URL: https://github.com/apache/datafusion-comet/pull/3253
## Summary Add comprehensive support for `TimestampNTZType` (Timestamp without timezone) wherever `TimestampType` is currently supported. **Key changes:** - Add `TimestampNTZType` to `CometCast.supportedTypes` - Support casting TimestampNTZ to Long, String, Date, and Timestamp - Add TimestampNTZ support to `unix_timestamp` function (no timezone conversion needed) - Add tests for TimestampNTZ casts and temporal expressions **Semantic differences from TimestampType:** - `unix_timestamp(TimestampNTZ)`: Simply divides microseconds by 1,000,000 (no timezone adjustment) - Cast to Date: Simple truncation (no timezone adjustment) - Cast to String: Format as local datetime without timezone suffix ## Test plan - [ ] Run cast tests: `./mvnw test -DwildcardSuites="CometCast"` - [ ] Run temporal expression tests: `./mvnw test -DwildcardSuites="CometTemporalExpression"` - [ ] Full test suite 🤖 Generated with [Claude Code](https://claude.ai/code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
