andygrove commented on PR #3212:
URL:
https://github.com/apache/datafusion-comet/pull/3212#issuecomment-3791015464
> Maybe we should use a profile to decide when to generate docs?
I went with `build.sh` because the doc generation is tightly coupled to the
Sphinx build step, and keeping it there ensures `mvn package` stays
deterministic (no modified files).
The workflow also has two different targets: during normal publishing, we
generate docs into a temp folder (so the repo stays clean), but during the
release process, we run `dev/generate-release-docs.sh` once to freeze the
generated content into the actual `docs` folder. A Maven profile would only
cover the first case cleanly, unless we added multiple profiles perhaps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
