alamb commented on code in PR #19954:
URL: https://github.com/apache/datafusion/pull/19954#discussion_r2722303088
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -4801,7 +4801,7 @@ async fn unnest_with_redundant_columns() -> Result<()> {
@r"
Projection: shapes.shape_id [shape_id:UInt32]
Unnest: lists[shape_id2|depth=1] structs[] [shape_id:UInt32,
shape_id2:UInt32;N]
- Aggregate: groupBy=[[shapes.shape_id]],
aggr=[[array_agg(shapes.shape_id) AS shape_id2]] [shape_id:UInt32,
shape_id2:List(Field { data_type: UInt32, nullable: true });N]
+ Aggregate: groupBy=[[shapes.shape_id]],
aggr=[[array_agg(shapes.shape_id) AS shape_id2]] [shape_id:UInt32,
shape_id2:List(UInt32);N]
Review Comment:
👍
##########
datafusion/sqllogictest/test_files/datetime/date_part.slt:
##########
@@ -40,11 +40,11 @@ with t as (values
)
SELECT
-- nanoseconds, with no, utc, and local timezone
- arrow_cast(column1, 'Timestamp(Nanosecond, None)') as ts_nano_no_tz,
+ arrow_cast(column1, 'Timestamp(ns)') as ts_nano_no_tz,
Review Comment:
I think it is valuable to have at least a few tests that verify the old
syntax still works, FWIW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
