andygrove opened a new pull request, #3258: URL: https://github.com/apache/datafusion-comet/pull/3258
## Summary - Modified "test multiple pages with different sizes and nulls" to use valid unsigned values, enabling it to run with all scan implementations - Created dedicated test for native_comet's handling of unsigned int types with values exceeding signed range ## Background The "test multiple pages with different sizes and nulls" test previously used negative values for unsigned integer Parquet types (UINT_8, UINT_16, UINT_32, UINT_64). These negative bit patterns represent large unsigned values that only native_comet can handle correctly, which limited test coverage to only that scan implementation. ## Changes This PR increases test coverage for `native_datafusion` and `native_iceberg_compat` scan implementations by: 1. **Modifying the existing test** to use valid unsigned values (non-negative integers within the unsigned range) so it can run with any scan implementation 2. **Extracting the edge case** into a dedicated test that explicitly verifies native_comet's ability to handle unsigned integer types when stored values exceed the signed range ## Test plan - [x] `ParquetReadV1Suite` passes - [x] `ParquetReadV2Suite` passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
