alamb commented on code in PR #19964: URL: https://github.com/apache/datafusion/pull/19964#discussion_r2723419999
########## docs/source/library-user-guide/functions/adding-udfs.md: ########## @@ -583,7 +583,6 @@ For async UDF implementation details, see [`async_udf.rs`](https://github.com/ap [`scalarudf`]: https://docs.rs/datafusion/latest/datafusion/logical_expr/struct.ScalarUDF.html [`create_udf`]: https://docs.rs/datafusion/latest/datafusion/logical_expr/fn.create_udf.html -[`process_scalar_func_inputs`]: https://docs.rs/datafusion/latest/datafusion/physical_expr/functions/fn.process_scalar_func_inputs.html Review Comment: this is not linked anywhere in the text that I could find ########## docs/source/user-guide/example-usage.md: ########## @@ -103,7 +103,7 @@ exported by DataFusion, for example: use datafusion::arrow::datatypes::Schema; ``` -For example, [DataFusion `25.0.0` dependencies] require `arrow` +For example, [DataFusion `26.0.0` dependencies] require `arrow` Review Comment: You can see a few lines lower the actual version is 26 ``` [datafusion `26.0.0` dependencies]: https://crates.io/crates/datafusion/26.0.0/dependencies ``` ########## docs/source/user-guide/concepts-readings-events.md: ########## @@ -87,16 +87,14 @@ This is a list of DataFusion related blog posts, articles, and other resources. - **2024-10-29** [Video: MiDAS Seminar Fall 2024 on "Apache DataFusion" by Andrew Lamb](https://www.youtube.com/watch?v=CpnxuBwHbUc) -- **2024-10-27** [Blog: Caching in DataFusion: Don't read twice](https://blog.haoxp.xyz/posts/caching-datafusion) +- **2024-10-27** [Blog: Caching in DataFusion: Don't read twice](https://blog.xiangpeng.systems/posts/caching-datafusion/) Review Comment: @XiangpengHao 's blog has moved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
