gabotechs commented on code in PR #19759:
URL: https://github.com/apache/datafusion/pull/19759#discussion_r2723810315
##########
datafusion/execution/src/memory_pool/mod.rs:
##########
@@ -367,8 +367,8 @@ impl MemoryReservation {
/// Frees all bytes from this reservation back to the underlying
/// pool, returning the number of bytes freed.
- pub fn free(&mut self) -> usize {
- let size = self.size;
+ pub fn free(&self) -> usize {
Review Comment:
That's right, this is not a breaking API change.
One thing that could happen is that people have some clippy lint that goes
off in case of "unused muts". In that case people will start seeing new clippy
warnings with DataFusion 53 in their own code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
