Jefffrey commented on code in PR #18828:
URL: https://github.com/apache/datafusion/pull/18828#discussion_r2724122932
##########
datafusion/execution/src/config.rs:
##########
@@ -480,6 +480,11 @@ impl SessionConfig {
self.options.execution.enforce_batch_size_in_joins
}
+ pub fn with_enable_ansi_mode(mut self, enable_ansi_mode: bool) -> Self {
Review Comment:
Do we still need this function? If so it needs a docstring
##########
datafusion/spark/src/function/math/abs.rs:
##########
@@ -185,45 +236,51 @@ mod tests {
use super::*;
use arrow::datatypes::i256;
- macro_rules! eval_legacy_mode {
- ($TYPE:ident, $VAL:expr) => {{
+ macro_rules! eval_with_mode {
Review Comment:
Is it possible to try move these tests to SLTs instead? Having so much macro
code just for unit tests isn't ideal here 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
