alamb commented on code in PR #19910:
URL: https://github.com/apache/datafusion/pull/19910#discussion_r2724127145
##########
datafusion/physical-expr-common/src/binary_map.rs:
##########
@@ -427,7 +427,7 @@ where
// Check if the value is already present in the set
let entry = self.map.find_mut(hash, |header| {
// compare value if hashes match
- if header.len != value_len {
+ if header.hash != hash {
Review Comment:
@Dandandan do we need to update this location too with a check for length?
```suggestion
if header.hash != hash || header.len != value_len {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
