Tushar7012 commented on PR #19975: URL: https://github.com/apache/datafusion/pull/19975#issuecomment-3794761519
Hi @Dandandan This PR implements the optimization you suggested in #19961. **Changes made:** - Use `values.views()` instead of `values.iter()` for direct `&[u128]` access - Use `is_valid(i)` for efficient null checking via validity bitmap - No additional memory overhead in Entry struct (per your feedback!) All 8 existing tests pass. Ready for review when you have time! Could you also approve the CI workflows to run? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
