masonh22 commented on code in PR #20048:
URL: https://github.com/apache/datafusion/pull/20048#discussion_r2737704680
##########
datafusion/sqllogictest/test_files/limit.slt:
##########
@@ -706,8 +706,8 @@ ON t1.b = t2.b
ORDER BY t1.b desc, c desc, c2 desc
OFFSET 3 LIMIT 2;
----
-3 99 82
-3 99 79
+3 98 79
+3 97 96
Review Comment:
The previous result was wrong. Look at the query directly above this. It
is identical except that this query adds `OFFSET 3 LIMIT 2`. None of the rows
in the previous test training are in the rows returned by the previous query,
and the new training I added is just rows 4-5 in that query.
What was happening here is the inner OFFSET/LIMITs were being removed by the
physical optimizer rule.
##########
datafusion/sqllogictest/test_files/union.slt:
##########
@@ -494,22 +494,25 @@ physical_plan
01)CoalescePartitionsExec: fetch=3
02)--UnionExec
03)----ProjectionExec: expr=[count(Int64(1))@0 as cnt]
-04)------AggregateExec: mode=Final, gby=[], aggr=[count(Int64(1))]
-05)--------CoalescePartitionsExec
-06)----------AggregateExec: mode=Partial, gby=[], aggr=[count(Int64(1))]
-07)------------ProjectionExec: expr=[]
-08)--------------AggregateExec: mode=FinalPartitioned, gby=[c1@0 as c1],
aggr=[]
-09)----------------RepartitionExec: partitioning=Hash([c1@0], 4),
input_partitions=4
-10)------------------AggregateExec: mode=Partial, gby=[c1@0 as c1], aggr=[]
-11)--------------------FilterExec: c13@1 != C2GT5KVyOPZpgKVl110TyZO0NcJ434,
projection=[c1@0]
-12)----------------------RepartitionExec: partitioning=RoundRobinBatch(4),
input_partitions=1
-13)------------------------DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/testing/data/csv/aggregate_test_100.csv]]}, projection=[c1,
c13], file_type=csv, has_header=true
-14)----ProjectionExec: expr=[1 as cnt]
-15)------PlaceholderRowExec
-16)----ProjectionExec: expr=[lead(b.c1,Int64(1)) ROWS BETWEEN UNBOUNDED
PRECEDING AND UNBOUNDED FOLLOWING@1 as cnt]
-17)------BoundedWindowAggExec: wdw=[lead(b.c1,Int64(1)) ROWS BETWEEN UNBOUNDED
PRECEDING AND UNBOUNDED FOLLOWING: Field { "lead(b.c1,Int64(1)) ROWS BETWEEN
UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING": nullable Int64 }, frame: ROWS
BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING], mode=[Sorted]
-18)--------ProjectionExec: expr=[1 as c1]
-19)----------PlaceholderRowExec
+04)------GlobalLimitExec: skip=0, fetch=3
Review Comment:
I think this is a better plan than before: `GlobalLimitExec`s are pushed
into the union, and before they were not pushed below `CoalescePartitionsExec`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
