sudheerv commented on a change in pull request #6708:
URL: https://github.com/apache/trafficserver/pull/6708#discussion_r414960734
##########
File path: proxy/logging/LogAccess.cc
##########
@@ -2631,6 +2631,55 @@
LogAccess::marshal_client_http_transaction_priority_dependence(char *buf)
return INK_MIN_ALIGN;
}
+/*-------------------------------------------------------------------------
+ -------------------------------------------------------------------------*/
+
+int
+LogAccess::marshal_cache_read_retries(char *buf)
+{
+ if (buf) {
+ int64_t id = 0;
+ if (m_http_sm) {
+ id = m_http_sm->get_cache_sm().get_open_read_tries();
+ }
+ marshal_int(buf, id);
+ }
+ return INK_MIN_ALIGN;
+}
+
+/*-------------------------------------------------------------------------
+ -------------------------------------------------------------------------*/
+
+int
+LogAccess::marshal_cache_write_retries(char *buf)
+{
+ if (buf) {
+ int64_t id = 0;
+ if (m_http_sm) {
+ id = m_http_sm->get_cache_sm().get_open_write_tries();
+ }
+ marshal_int(buf, id);
+ }
+ return INK_MIN_ALIGN;
+}
+
+int
+LogAccess::marshal_cache_collapsed_connection_success(char *buf)
+{
+ if (buf) {
+ int64_t id = 0;
+ if (m_http_sm) {
+ SquidLogCode code = m_http_sm->t_state.squid_codes.log_code;
+ if ((m_http_sm->get_cache_sm().get_open_write_tries() ==
(m_http_sm->t_state.txn_conf->max_cache_open_write_retries + 1)) &&
Review comment:
Does it makes sense to set this to may be `-1` when CF was never
attempted to distinguish from a failed attempt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
