SolidWallOfCode commented on a change in pull request #6712:
URL: https://github.com/apache/trafficserver/pull/6712#discussion_r416699943



##########
File path: iocore/net/P_UnixNet.h
##########
@@ -506,9 +531,7 @@ check_transient_accept_error(int res)
   }
 }
 
-//
-// Disable a NetEvent
-//
+/// Disable the read epoll on a NetEvent

Review comment:
       This needs a lot more detail.
   ```
   /** Disable reading on the NetEvent @a ne
        @param nh Nethandler that owns @a ne
        @param ne The @c NetEvent to modify.
   
        - If write is already disable, also disable the inactivity timeout.
        - Remove the @c epoll READ flag.
        - Take @a ne out of the read ready list.
   */ 
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to