maskit commented on a change in pull request #6731:
URL: https://github.com/apache/trafficserver/pull/6731#discussion_r419191476
##########
File path: iocore/cache/P_CacheTest.h
##########
@@ -44,7 +44,7 @@ struct PinnedDocTable : public Continuation {
int remove(CacheKey *key);
int cleanup(int event, Event *e);
- PinnedDocTable() : Continuation(new_ProxyMutex()) { memset(bucket, 0,
sizeof(Queue<PinnedDocEntry>) * PINNED_DOC_TABLE_SIZE); }
+ PinnedDocTable() : Continuation(new_ProxyMutex()) { ink_zero(bucket); }
Review comment:
Do we need this initialization? `Queue`'s constructor should be called
as long as this constructor is called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
