ywkaras commented on a change in pull request #5812: URL: https://github.com/apache/trafficserver/pull/5812#discussion_r420986674
########## File path: tests/gold_tests/pluginTest/msg_comp/log.gold ########## @@ -0,0 +1,50 @@ +Global: event=TS_EVENT_HTTP_SEND_RESPONSE_HDR + +Remap From URL: http://one/ +Remap To URL: http://127.0.0.1:SERVER_PORT/ +Effective URL: http://127.0.0.1:SERVER_PORT/argh + +Client Request: +method=GET +absUrl=http://127.0.0.1:SERVER_PORT/argh +version=1.1 +hdrLength=163 +Host: 127.0.0.1:SERVER_PORT +User-Agent: curl/7.61.1 +Accept: */* +Connection: close +X-Crap: one, two, three +X-Crap: four + +Client Response: +status=200 +reason=OK +version=1.1 +hdrLength=131 +Date: `` +Age: 0 +Transfer-Encoding: chunked +Connection: close +Server: ATS/`` + +Server Request: +method=GET +absUrl=127.0.0.1:SERVER_PORT/argh +version=1.1 +hdrLength=283 +Host: 127.0.0.1:SERVER_PORT +User-Agent: curl/7.61.1 +Accept: */* +X-Crap: one, two, three +X-Crap: alpha, beta, gamma +Client-ip: 127.0.0.1 +X-Forwarded-For: 127.0.0.1 +Via: http/1.1 Poxy_Proxy[`` + +Server Response: +status=200 +reason=OK +version=1.1 +hdrLength=75 +Connection: close Review comment: Better to wild card Connection field in responses, and remove 'Connection: close' from request. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
