masaori335 opened a new pull request #6747: URL: https://github.com/apache/trafficserver/pull/6747
MIMEHdr GC is introduced by 2bbcc48195e98b65b681a7e28c9ae1c2ab5d6994. However, @maskit noticed possible issues with old MIMEHdr handling. 1. When a new entry is larger than the maximum size, the current `MIMEHdr` is cleared, but the old `MIMEHdr` is not. This could be a leak. 2. On eviction, `_mhdr->field_delete()` is called, but `_mhdr_old` should be used in some cases. GC is **accidentally** working, because `mime_field_destroy()` mark the `MIMEField` `MIME_FIELD_SLOT_READINESS_DELETED` regardless of given `MIMEHdr` and `_mhdr_old->fields_count()` becomes 0. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
