shinrich opened a new pull request #6771: URL: https://github.com/apache/trafficserver/pull/6771
The CI has been broken because of autest failures in tls_hooks* tests. The problem was that the handshake timeout default to 0, and setting inactivity timeout to 0 was causing the ssl netvc object to be deleted on the next inactivity cop iteration. This happened because of a clean up in 66f23063e1cb44ec04136853952dc299303a832d which removed logic to set the timeout to the default inactivity timeout if the timeout argument was 0. The documentation for the handshake timeout seems to imply that setting it to 0 should disable the timeout. Also commit from me from January 2018 remove the logic that read the configuration to set the tls handshake timeout. This PR adds that back in. It isn't clear to me what the correct solution. To get the CI going again, I'm adding back the if statement to go back to the previous behavior with respect to 0 inactivity timeouts. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
