ywkaras commented on a change in pull request #6800:
URL: https://github.com/apache/trafficserver/pull/6800#discussion_r427423658



##########
File path: include/tscpp/api/Plugin.h
##########
@@ -142,6 +143,15 @@ class Plugin : noncopyable
     transaction.resume();
   };
 
+  /**
+   * This method must be implemented when you hook HOOK_TXN_CLOSE
+   */
+  virtual void
+  handleTxnClose(Transaction &transaction)
+  {
+    transaction.resume();

Review comment:
       You would not want to call resume here (leave this function empty) if 
you take my suggestion to move the call to this member function to 
cleanupTransactionPlugin() .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to