SolidWallOfCode commented on a change in pull request #6707:
URL: https://github.com/apache/trafficserver/pull/6707#discussion_r428285958
##########
File path: proxy/hdrs/HdrTSOnly.cc
##########
@@ -59,6 +59,11 @@ HTTPHdr::parse_req(HTTPParser *parser, IOBufferReader *r,
int *bytes_used, bool
ParseResult state = PARSE_RESULT_CONT;
*bytes_used = 0;
+ // FIXME: r maybe no has IObufferBlock object
Review comment:
This isn't required because of the `r->block_read_avail()` a bit later.
The code for that does the null check on the block -
https://github.com/SolidWallOfCode/trafficserver/blob/master/iocore/eventsystem/P_IOBuffer.h#L493
Therefore it it returns a result > 0 then there is guaranteed to be a block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
