maskit commented on pull request #6836: URL: https://github.com/apache/trafficserver/pull/6836#issuecomment-636685674
I haven't reviewed the detail but here is early feedback: - We should probably have a build option to enable qlog - I don't think we want to enable it on production - Filename should probably contain some id (e.g. CID, timestamp) - I'm not sure why we need to put `YAMLCPP_INCLUDES` here and there ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
