masaori335 commented on pull request #6868: URL: https://github.com/apache/trafficserver/pull/6868#issuecomment-640945868
Right. PluginTag was used for logging HTTP versions as a workaround fix before. I think we got rid of it completely. I do agree with calling `dynamic_cast` for every transaction is wasting CPU. I'm not familiar with PluginVC, but using the `is_internal_request` flag looks reasonable. Because it's set by `TSHttpConnectWithPluginId()` and `TSHttpConnectTransparent()`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
