ywkaras commented on a change in pull request #6860:
URL: https://github.com/apache/trafficserver/pull/6860#discussion_r437420314



##########
File path: plugins/cache_range_requests/cache_range_requests.cc
##########
@@ -479,7 +479,8 @@ handle_cache_lookup_complete(TSHttpTxn txnp, txndata *const 
txn_state)
   if (TS_SUCCESS == TSHttpTxnCacheLookupStatusGet(txnp, &cachestat)) {
     if (TS_CACHE_LOOKUP_HIT_FRESH == cachestat) {
       time_t const ch_time = get_date_from_cached_hdr(txnp);
-      DEBUG_LOG("IMS Cached header time %" PRId64 " vs IMS %" PRId64, ch_time, 
txn_state->ims_time);
+      DEBUG_LOG("IMS Cached header time %jd vs IMS %jd", 
static_cast<intmax_t>(ch_time),
+                static_cast<intmax_t>(txn_state->ims_time));

Review comment:
       If you prefer to cast to intmax_t then why not use PRIdMAX as the format 
specifier?  https://en.cppreference.com/w/cpp/header/cinttypes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to