SolidWallOfCode commented on a change in pull request #6732:
URL: https://github.com/apache/trafficserver/pull/6732#discussion_r437745039
##########
File path: proxy/http/Http1ClientSession.cc
##########
@@ -373,11 +367,7 @@ Http1ClientSession::state_keep_alive(int event, void *data)
break;
case VC_EVENT_EOS:
- this->do_io_close();
- if (_vc != nullptr) {
- _vc->do_io_close();
- _vc = nullptr;
- }
+ this->do_io_close(EHTTP_ERROR);
Review comment:
Explained in person - this is to force full close, never half close.
Might be better to not pass an error and explicitly set `half_close = false;`
but it's a minor point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
