masaori335 commented on a change in pull request #6881:
URL: https://github.com/apache/trafficserver/pull/6881#discussion_r438466289
##########
File path: proxy/http2/Http2Stream.cc
##########
@@ -451,12 +451,9 @@ Http2Stream::initiating_close()
}
// Send EOS to let SM know that we aren't sticking around
if (_sm && read_vio.cont) {
- // Only bother with the EOS if we haven't sent the write complete
- if (!sent_write_complete) {
Review comment:
Does this mean this function sends VC_EVENT_EOS even if
VC_EVENT_WRITE_COMPLETE was sent? Looks a bit weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
