masaori335 commented on pull request #6869:
URL: https://github.com/apache/trafficserver/pull/6869#issuecomment-645714401
> > 1. `iobuffer_size_to_index()` vs `buffer_size_to_index()`
[snip]
> [Sudheer ] No, the idea is to enforce the caller pass the explicit buffer
size as opposed to the iobuf library determining silently which could be
problematic as it's hard to find a common default value that satisfies all use
cases.
>
I agree with it's hard to find a common default value that satisfies all use
cases. It's rarely tuned.
[snip]
> > 1. Some `iobuffer_size_to_index()` calls has value from dedicated
records.config, others has fixed value (`BUFFER_SIZE_INDEX_32K`). What's the
policy of this difference?
>
> [Sudheer] Yeah, ideally we'd like all the use cases to have a config. I
skipped QUIC use cases alone for the time being to revisit in the future when
they are being used in prod as we'd then have a clearer picture on whether we
need this stuff configurable and if so how many configs are needed (seems like
there's tons of cases in QUIC). Do you recommend adding it to that as well?
I didn't notice they're only in the QUIC land. IMO, almost all of them are
good with the current default value ( `BUFFER_SIZE_INDEX_32K` ). /cc @maskit
I worried about we need to add a ton of configs, but it looks like we can
break down `proxy.config.io.max_buffer_size` into only 4 configs except for
QUIC. Because many MIOBuffer has hardcoded value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
