randall commented on a change in pull request #6489:
URL: https://github.com/apache/trafficserver/pull/6489#discussion_r442360471
##########
File path: iocore/net/UnixNetProcessor.cc
##########
@@ -237,16 +237,18 @@ UnixNetProcessor::connect_re_internal(Continuation *cont,
sockaddr const *target
vc->action_ = cont;
}
- MUTEX_TRY_LOCK(lock, cont->mutex, t);
- if (lock.is_locked()) {
- MUTEX_TRY_LOCK(lock2, get_NetHandler(t)->mutex, t);
- if (lock2.is_locked()) {
- int ret;
- ret = vc->connectUp(t, NO_FD);
- if ((using_socks) && (ret == CONNECT_SUCCESS)) {
- return &socksEntry->action_;
- } else {
- return ACTION_RESULT_DONE;
+ if (reinterpret_cast<EThread *>(this_thread()) == t) {
Review comment:
I guess it seems like burying the lede here. The subject of the PR just
mentions tests, but it looks like a general change in behavior here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
