bneradt commented on a change in pull request #6931:
URL: https://github.com/apache/trafficserver/pull/6931#discussion_r444454565
##########
File path: src/traffic_server/traffic_server.cc
##########
@@ -2094,7 +2116,11 @@ main(int /* argc ATS_UNUSED */, const char **argv)
if (delay_p && ink_atomic_cas(&delay_listen_for_cache_p, 0, 1)) {
Debug("http_listen", "Delaying listen, waiting for cache
initialization");
} else {
+ // Since the previous delay_listen_for_cache_p was not 0, then the
+ // cache must have been initialized already.
Review comment:
I'm open to improving the comment. What are you fixing about it? Is it
wrong to say that the cache must have been initialized by this point? As I read
things, if we get to this branch then the value must have been -1 and thus the
cache must be initialized and I'm trying to help the reader see that's the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
