bneradt commented on a change in pull request #6931:
URL: https://github.com/apache/trafficserver/pull/6931#discussion_r445050944
##########
File path: tests/gold_tests/autest-site/trafficserver.test.ext
##########
@@ -281,10 +282,26 @@ def MakeATSProcess(obj, name, command='traffic_server',
select_ports=True, enabl
get_port(p, "manager_port")
get_port(p, "admin_port")
- if enable_tls:
- p.Ready = When.PortsOpen([p.Variables.port, p.Variables.ssl_port])
+ if enable_cache:
+ # In records.config, the cache is enabled by default so there's nothing
+ # we have to do here to functionally enable it. However, the tests that
+ # rely upon the cache will not function correctly if ATS starts
+ # processing traffic before the cache is ready. Thus we set the
+ # wait_for_cache configuration.
+ p.Disk.records_config.update({
+ # Do not accept connections from clients until cache subsystem is
+ # operational.
+ 'proxy.config.http.wait_for_cache': 1,
Review comment:
I generally prefer keeping the comma for the last item as a convenience
if another item is appended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
