gtenev commented on a change in pull request #6880:
URL: https://github.com/apache/trafficserver/pull/6880#discussion_r446284983
##########
File path: proxy/http/remap/PluginFactory.cc
##########
@@ -82,7 +82,7 @@ RemapPluginInst::osResponse(TSHttpTxn rh, int
os_response_type)
_plugin.osResponse(_instance, rh, os_response_type);
}
-PluginFactory::PluginFactory()
+PluginFactory::PluginFactory(const DLL<PluginRegInfo> &globalPluginRegistry)
Review comment:
I wonder if we can redesign this to be simpler and more modular and
avoid the unnecessary (AFAICT) coupling between the global plugin loading and
remap plugin loading subsystems (please see my next comment).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
