masaori335 commented on a change in pull request #6958:
URL: https://github.com/apache/trafficserver/pull/6958#discussion_r446708625
##########
File path: plugins/experimental/icap/icap_plugin.cc
##########
@@ -28,6 +28,7 @@
#include <string>
#include <regex>
+#include <inttypes.h>
Review comment:
Kind of nitpicking, but `<inttypes.h>` is deprecated. `<cinttypes>` is a
replacement.
> `<inttypes.h>`(C++11)(deprecated) | Behaves as if each name from
`<cinttypes>` is placed in global namespace
https://en.cppreference.com/w/cpp/header%23C_compatibility_headers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
