shinrich commented on a change in pull request #6968:
URL: https://github.com/apache/trafficserver/pull/6968#discussion_r448395719
##########
File path: doc/admin-guide/files/records.config.en.rst
##########
@@ -414,19 +414,20 @@ Network
.. ts:cv:: CONFIG proxy.config.net.max_connections_in INT 30000
- The total number of client connections that the :program:`traffic_server`
- can handle simultaneously. This should be tuned according to your memory
size,
- and expected work load (network, cpu etc). This limit includes both
keepalive
- and active client connections that :program:`traffic_server` can handle at
- any given instant.
-
-.. ts:cv:: CONFIG proxy.config.net.max_active_connections_in INT 10000
-
- The total number of active client connections that the |TS| can handle
- simultaneously. This should be tuned according to your memory size,
- and expected work load (network, cpu etc). If this is set to 0, active
- connection tracking is disabled and active connections have no separate
- limit and the total connections follow
`proxy.config.net.connections_throttle`
+ The total number of client requests that |TS| can handle simultaneously.
+ This should be tuned according to your memory size, and expected work load
+ (network, cpu etc). This limit includes both idle (keep alive) connections
+ and active requests that |TS| can handle at any given instant. The delta
+ between `proxy.config.net.max_connections_in` and
`proxy.config.net.max_requests_in`
+ is the amount of maximum idle (keepalive) connections |TS| will maintain.
+
+.. ts:cv:: CONFIG proxy.config.net.max_requests_in INT 0
+
+ The total number of concurrent requests or active client connections
+ that the |TS| can handle simultaneously. This should be tuned according
+ to your memory size, and expected work load (network, cpu etc). When
+ set to 0, active request tracking is disabled and max requests has no
+ separate limit and the total connections follow
`proxy.config.net.connections_throttle`
Review comment:
I know there was a discussion that for HTTP/2 it would make more sense
to track this at the stream level (10 active streams on a Http2 Session would
count as 10 active requests instead of 1). But I don't think that it how it is
currently coded and this PR doesn't change that. But the change in the
documentation does imply that. Or am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
