masaori335 commented on a change in pull request #6889:
URL: https://github.com/apache/trafficserver/pull/6889#discussion_r451926362
##########
File path: proxy/http2/Http2ConnectionState.cc
##########
@@ -242,7 +242,7 @@ rcv_headers_frame(Http2ConnectionState &cstate, const
Http2Frame &frame)
if (cstate.is_valid_streamid(stream_id)) {
stream = cstate.find_stream(stream_id);
if (stream == nullptr || !stream->has_trailing_header()) {
- return Http2Error(Http2ErrorClass::HTTP2_ERROR_CLASS_CONNECTION,
Http2ErrorCode::HTTP2_ERROR_STREAM_CLOSED,
Review comment:
Is this for `http2/6.2/2` of h2spec?
5.1. Stream States says below
> closed:
> An endpoint that receives any frame other than PRIORITY
> after receiving a RST_STREAM MUST treat that as a stream error
> (Section 5.4.2) of type STREAM_CLOSED.
Probably, we need to break down the conditions in line 244
- `stream == nullptr` -> `STREAM_CLOSED`
- `!stream->has_trailing_header()` -> HTTP2_ERROR_PROTOCOL_ERROR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
