maskit commented on a change in pull request #6977:
URL: https://github.com/apache/trafficserver/pull/6977#discussion_r452573874
##########
File path: iocore/net/UnixNetVConnection.cc
##########
@@ -1394,8 +1394,10 @@ UnixNetVConnection::migrateToCurrentThread(Continuation
*cont, EThread *t)
hold_con.move(this->con);
SSLNetVConnection *sslvc = dynamic_cast<SSLNetVConnection *>(this);
- SSL *save_ssl = (sslvc) ? sslvc->ssl : nullptr;
+ SSL *save_ssl = (sslvc) ? sslvc->ssl : nullptr;
+ const char *hold_ssl_client_cert_name = "";
if (save_ssl) {
+ hold_ssl_client_cert_name = sslvc->options.ssl_client_cert_name;
Review comment:
Hmm, are you suggesting I should add lines like this if I needed values
in other fields? What would be a problem if we copied entire `options`?
I was surprised that this function copies only a few part of information in
a NetVC. I'd be confused if I printed information in a NetVC for debugging
after a migration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
