ezelkow1 commented on a change in pull request #6980: URL: https://github.com/apache/trafficserver/pull/6980#discussion_r453116087
########## File path: plugins/experimental/maxmind_acl/maxmind_acl.cc ########## @@ -0,0 +1,117 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +#include "mmdb.h" + +static int +config_handler(TSCont cont, TSEvent event, void *edata) +{ + TSMutex mutex; + + mutex = TSContMutexGet(cont); + TSMutexLock(mutex); Review comment: Looking at other plugins, it appears this is only supported when they are running as global plugins anyway. So for now I will go back when I get a chance and rip out all of the config reloading stuff since it just flat out doesnt work for remap plugins the way that mgmt functionality is implemented anyway ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
