calavera commented on a change in pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005#discussion_r455317929



##########
File path: .vscode/tasks.json
##########
@@ -3,6 +3,20 @@
     // for the documentation about the tasks.json format
     "version": "2.0.0",
     "tasks": [
+        {
+            "label": "Autoreconf",
+            "type": "shell",
+            "command": "autoreconf -if",
+            "problemMatcher": []
+        },
+        {
+            "label": "Configure",
+            "type": "shell",
+            "command": "./configure --prefix=/opt/ats --enable-ccache  
--enable-experimental-plugins --enable-example-plugins --enable-test-tools 
--enable-debug --enable-werror",

Review comment:
       unless root access is absolutely necessary, I would not set the prefix 
in /opt. It also has the inconvenient of being global. I don't know if it's 
possible to use the workspace variable in this string, but something like 
`${workspaceFolder}/target` might be better.
   
   This is not a strong opinion, so feel free to not change anything.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to