gtenev commented on a change in pull request #7028:
URL: https://github.com/apache/trafficserver/pull/7028#discussion_r459109200
##########
File path: iocore/cache/Cache.cc
##########
@@ -2754,14 +2759,36 @@ cplist_reconfigure()
Warning("no volumes created");
return -1;
}
- int64_t space_in_blks = static_cast<int64_t>(((config_vol->percent /
percent_remaining)) * tot_space_in_blks);
+
+ // Find if the volume is forced and if it is then calculate the total
forced volume size.
+ // Forced volumes take the whole span (disk) also sum all disk space
this volume is forced to.
+ bool forcedVolume = false;
Review comment:
OK, fixed. Although I thought it is more human-readable with the `bool`
(also it is a stack variable in a non-performance-critical path, possibly also
will be optimized out).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
