bneradt commented on a change in pull request #7046:
URL: https://github.com/apache/trafficserver/pull/7046#discussion_r461124797
##########
File path: proxy/http3/Http3App.h
##########
@@ -106,6 +106,6 @@ class Http3SettingsFramer : public Http3FrameGenerator
private:
NetVConnectionContext_t _context;
- bool _is_done = false; ///< Becarefull when set FIN flag on CONTROL stream.
Maybe never?
+ bool _is_done = false; ///< be careful when set FIN flag on CONTROL stream.
Maybe never?
Review comment:
Probably good to capitalize that first 'b' here to be consistent with
the next comment.
##########
File path: iocore/net/quic/QUICAckFrameCreator.h
##########
@@ -69,7 +69,7 @@ class QUICAckFrameManager : public QUICFrameGenerator
bool _available = false; // packet_number has data
to sent
bool _should_send = false; // ack frame should be
sent immediately
bool _has_new_data = false; // new data after last
sent
- uint32_t _ack_eliciting_count = 0; // every two
ack-eliciting packet should send ack immediatly
+ uint32_t _ack_eliciting_count = 0; // every two
ack-eliciting packet should send ack imeediately
Review comment:
imeediately
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
