zizhong commented on a change in pull request #7056:
URL: https://github.com/apache/trafficserver/pull/7056#discussion_r461959978
##########
File path: proxy/http/Http1ClientSession.cc
##########
@@ -261,8 +261,8 @@ Http1ClientSession::do_io_close(int alerrno)
} else {
HttpSsnDebug("[%" PRId64 "] session closed", con_id);
HTTP_SUM_DYN_STAT(http_transactions_per_client_con, transact_count);
- if (read_state != HCS_ACTIVE_READER) {
- // donot double decrement
+ if (conn_decrease) {
Review comment:
We are increasing the stat in `new_connection()`, so I think it should
be sufficient that we decrease the stat in `free()`.
Could you help me understand what is the reason that we have it in
`do_io_close()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
